dawidwys commented on a change in pull request #10942: [FLINK-15487][table]
Allow registering FLIP-65 functions in TableEnvironment
URL: https://github.com/apache/flink/pull/10942#discussion_r371781417
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -273,6 +274,72 @@ public void registerFunction(String name, ScalarFunction
function) {
function);
}
+ @Override
+ public void createTemporarySystemFunction(String name, Class<? extends
UserDefinedFunction> functionClass) {
+ final UserDefinedFunction functionInstance =
UserDefinedFunctionHelper.instantiateFunction(functionClass);
Review comment:
Just as a future reference. I think we should change the `FunctionCatalog`
so that it stores temporary functions as `CatalogFunctions` instead of
instances of `FunctionDefinition` the same way we store `CatalogTables` for
temporary tables.
Shall we create a follow-up issue for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
