twalthr commented on a change in pull request #10942: [FLINK-15487][table]
Allow registering FLIP-65 functions in TableEnvironment
URL: https://github.com/apache/flink/pull/10942#discussion_r372283609
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/rules/ResolveCallByArgumentsRule.java
##########
@@ -97,7 +97,13 @@
@Override
public List<ResolvedExpression> visit(UnresolvedCallExpression
unresolvedCall) {
- final FunctionDefinition definition =
prepareUserDefinedFunction(unresolvedCall.getFunctionDefinition());
+ final FunctionDefinition definition;
+ // clean functions that were not registered in a catalog
+ if
(!unresolvedCall.getFunctionIdentifier().isPresent()) {
Review comment:
Yes, this is a shortcoming. I will create a follow up issue for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
