tzulitai opened a new pull request #6: [FLINK-15818] [kafka-io] Add startup postition configuration for Kafka ingress YAML support URL: https://github.com/apache/flink-statefun/pull/6 This is a follow-up to #5, and is based on that PR. It extends the addition of configuring startup position / auto offset reset position / consumer group id to the YAML-based Kafka ingress. Only the last 3 commits starting from c09fcd2 is relevant. Moreover, this PR unifies the source creation logic between `ProtobufKafkaSourceProvider` and `KafkaSourceProvider`, to be always delegated through `KafkaSourceProvider`. With this change, the `ProtobufKafkaSourceProvider` only deals with parsing the Json ingress spec into a `KafkaIngressSpec`, and delegates the actual creation of the Flink Kafka source to a `KafkaSourceProvider`. This allows us to consolidate configuration validation logic in a single place (builder + `KafkaIngressSpec`).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
