igalshilman commented on a change in pull request #6: [FLINK-15818] [kafka-io]
Add startup postition configuration for Kafka ingress YAML support
URL: https://github.com/apache/flink-statefun/pull/6#discussion_r373440237
##########
File path:
statefun-flink/statefun-flink-common/src/main/java/org/apache/flink/statefun/flink/common/json/Selectors.java
##########
@@ -89,6 +100,34 @@ public static int integerAt(JsonNode node, JsonPointer
pointer) {
return properties;
}
+ public static Map<String, Long> longPropertiesAt(JsonNode node, JsonPointer
pointer) {
Review comment:
Can you add a test for that in `SelectorsTest` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
