tzulitai opened a new pull request #7: [FLINK-15839] [kafka-io] Fix Stateful Functions KafkaIngressBuilder properties resolution logic URL: https://github.com/apache/flink-statefun/pull/7 This PR revisits how we resolve configs for the `KafkaIngressBuilder`, given that we have: - Named configuration methods for important settings - Some of which have default values, some don't - Some eventually resolve as a Kafka client property, some are not - At the same time, also accept a `Properties` which may also explicitly define values for the above. The end result of the changes in this PR is as follows: - Configs passed via named methods should always overwrite the value set via passed in `Properties` - Any default values for named configuration methods should be defined in the builder - If no config was passed via its named method, then we use the default value (if any) to overwrite the properties IFF the user also did not provide a value for it there. --- The individual commits and their messages / descriptions should be sufficient in explaining what was changed to achieve this. --- New tests in `KafkaIngressBuilderTest` was added to verify the changes. Please also see there to get an overview of the expected behaviour.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
