igalshilman commented on a change in pull request #7: [FLINK-15839] [kafka-io]
Fix Stateful Functions KafkaIngressBuilder properties resolution logic
URL: https://github.com/apache/flink-statefun/pull/7#discussion_r374097821
##########
File path:
statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressBuilder.java
##########
@@ -168,13 +174,20 @@ private Properties resolveKafkaProperties() {
}
}
+ private static <T> void overwritePropertyIfNamedConfigIsPresent(
Review comment:
Suggestion: Since `OptionalConfig` is a package private class, moving this
method into the `OptionalConfig` might make it a bit more readable.
For example:
```
ConsumerConfig.GROUP_ID.upadte(properties, consumerGroupId);
```
Either way is good tho!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
