[
https://issues.apache.org/jira/browse/FLINK-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028729#comment-17028729
]
Dawid Wysakowicz commented on FLINK-15771:
------------------------------------------
We came to the same conclusion with [~aljoscha].
Personally I don't like the automatic, generic sorting in our IT tests. I think
it might be quite surprising at times, as it was surprising for me in this
case. There are cases when I think it makes sense to assert also on the order.
I'd be inclined to rather rework this IT test so that it produces deterministic
results. I would start though with collecting a list of features that it tries
to test. Right now it's unclear for me what is actually being testes and what
is asserted there by coincidence.
> SQLClientKafkaITCase.testKafka failed on Travis
> -----------------------------------------------
>
> Key: FLINK-15771
> URL: https://issues.apache.org/jira/browse/FLINK-15771
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Kafka, Table SQL / Client, Tests
> Affects Versions: 1.10.0, 1.11.0
> Reporter: Till Rohrmann
> Assignee: Dawid Wysakowicz
> Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0, 1.11.0
>
>
> The end-to-end test {{SQLClientKafkaITCase.testKafka}} failed with
> {code}
> 22:09:36.957 [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 129.244 s <<< FAILURE! - in
> org.apache.flink.tests.util.kafka.SQLClientKafkaITCase
> 22:09:36.958 [ERROR] testKafka[2: kafka-version:universal
> kafka-sql-version:.*kafka.jar](org.apache.flink.tests.util.kafka.SQLClientKafkaITCase)
> Time elapsed: 45.954 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...-03-12 09:00:00.000,[Bob,This was another warning.,1,Success
> constant folding.
> 2018-03-12 09:00:00.000,Steve,This was another info.,2],Success constant
> fo...> but was:<...-03-12 09:00:00.000,[Steve,This was another
> info.,2,Success constant folding.
> 2018-03-12 09:00:00.000,Bob,This was another warning.,1],Success constant
> fo...>
> at
> org.apache.flink.tests.util.kafka.SQLClientKafkaITCase.checkCsvResultFile(SQLClientKafkaITCase.java:226)
> at
> org.apache.flink.tests.util.kafka.SQLClientKafkaITCase.testKafka(SQLClientKafkaITCase.java:154)
> 22:09:37.287 [INFO]
> 22:09:37.288 [INFO] Results:
> 22:09:37.288 [INFO]
> 22:09:37.288 [ERROR] Failures:
> 22:09:37.288 [ERROR]
> SQLClientKafkaITCase.testKafka:154->checkCsvResultFile:226
> expected:<...-03-12 09:00:00.000,[Bob,This was another warning.,1,Success
> constant folding.
> {code}
> https://api.travis-ci.org/v3/job/641346345/log.txt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
