tzulitai commented on a change in pull request #7: [FLINK-15839] [kafka-io] Fix
Stateful Functions KafkaIngressBuilder properties resolution logic
URL: https://github.com/apache/flink-statefun/pull/7#discussion_r374447329
##########
File path:
statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressSpec.java
##########
@@ -75,12 +72,41 @@ public KafkaIngressStartupPosition startupPosition() {
return startupPosition;
}
- private static void validateStartupPosition(
- KafkaIngressStartupPosition startupPosition, @Nullable String
groupIdConfig) {
- if (startupPosition.isGroupOffsets() && groupIdConfig == null) {
+ private static Properties requireValidProperties(Properties properties) {
Review comment:
I don't have a strong stand on this though.
For a better separation of responsibility wise, it could make sense to still
move this to the builder yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
