tzulitai commented on a change in pull request #7: [FLINK-15839] [kafka-io] Fix
Stateful Functions KafkaIngressBuilder properties resolution logic
URL: https://github.com/apache/flink-statefun/pull/7#discussion_r374447170
##########
File path:
statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressSpec.java
##########
@@ -75,12 +72,41 @@ public KafkaIngressStartupPosition startupPosition() {
return startupPosition;
}
- private static void validateStartupPosition(
- KafkaIngressStartupPosition startupPosition, @Nullable String
groupIdConfig) {
- if (startupPosition.isGroupOffsets() && groupIdConfig == null) {
+ private static Properties requireValidProperties(Properties properties) {
Review comment:
The only "downside" I had in mind when not implementing this in the builder
was that it is slightly more dangerous implementing it there, because the
timeliness of when the validation was done will affect the end result (before /
after the properties resolution).
Just add one little bit of space to go wrong, although very trivial.
Being done in the `KafkaIngressSpec`, this should not be the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
