dawidwys commented on issue #11017: [FLINK-15907] [runtime] [configuration] 
expose getRawValue as protect…
URL: https://github.com/apache/flink/pull/11017#issuecomment-582302171
 
 
   I agree with you in principle. I am also sceptical about this change for the 
same reasons. My take is that `Configuration` was certainly not designed to be 
extensible.
   
   I think simply using `ReadableConfig` is not a solution to @stevenzwu use 
case as it is used only in a couple of locations. Majority of the code still 
uses Configuration. Similar approach to `ReadableConfigToConfigurationAdapter` 
could work but this has also limitation (that's why it is internal). It is not 
writable/it does not give access to all the keys/map of string based properties 
etc.). This would be my suggested way nevertheless. I think this can achieve 
the same goal as making the `getRawValue` method protected. It certainly 
requires more code on the user side, as basically the whole `Configuration` has 
to be reimplemented.
   
   To sum up, I would not include this change as it creates a contract we 
rather don't want to maintain while the same goal can be achieved in a 
different way .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to