stevenzwu edited a comment on issue #11017: [FLINK-15907] [runtime] 
[configuration] expose getRawValue as protect…
URL: https://github.com/apache/flink/pull/11017#issuecomment-582724007
 
 
   I might have spoken too soon. It seems like we do use the set APIs 
occasionally. I need to investigate, but there is a good chance that they are 
unnecessary.
   ```
   setInteger(RestOptions.PORT, restPort)
   setString(JobManagerOptions.ADDRESS, hostname)
   ```
   
   Also does Flink code internally call any set APIs from `Configuration` class?
   
   maybe I should also be more specific on what we are doing. We are passing 
our extension of Configuration class to `TaskManagerRunner`. if we pass in 
`ReadableConfigToConfigurationAdapter`, would it work for Flink?
   ```
   public TaskManagerRunner(Configuration configuration, ResourceID resourceId) 
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to