TisonKun commented on a change in pull request #10980:
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r375631555
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
##########
@@ -64,32 +69,46 @@
@BeforeClass
public static void setup() {
YARN_CONFIGURATION.set(YarnTestBase.TEST_CLUSTER_NAME_KEY,
"flink-yarn-tests-per-job");
- startYARNWithConfig(YARN_CONFIGURATION);
+ startYARNWithConfig(YARN_CONFIGURATION, true);
Review comment:
I'd suggest you just create a new file and write class about yarn file
replication, without any modification on `YARNITCase`. It doesn't no harm we
add a new file(test case) and if we keep modifying existing file for "patching"
logics we highly possibly run into mess.
Besides, still you don't test
```
configuration.setInteger(YarnConfigOptions.FILE_REPLICATION, 4);
```
with value expect `4` especially edge case such as `< -1` `== -1`(possibly
`<= -1` is ok) `== 0` `== 1`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
