TisonKun commented on a change in pull request #10980: 
[FLINK-12343][flink-yarn] add yarn file replication configuration
URL: https://github.com/apache/flink/pull/10980#discussion_r375633169
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
 ##########
 @@ -64,32 +69,46 @@
        @BeforeClass
        public static void setup() {
                YARN_CONFIGURATION.set(YarnTestBase.TEST_CLUSTER_NAME_KEY, 
"flink-yarn-tests-per-job");
-               startYARNWithConfig(YARN_CONFIGURATION);
+               startYARNWithConfig(YARN_CONFIGURATION, true);
 
 Review comment:
   A reason that I suggest add a new file is that previously we test 
`YARNITCase` with `withDFS == false` but now they are all `true`. I don't see 
an obvious reason to do it and we possibly loss test coverage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to