JingsongLi commented on a change in pull request #11034: [FLINK-15802][table]
Support new type inference for table functions
URL: https://github.com/apache/flink/pull/11034#discussion_r376199644
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/QueryOperationConverter.java
##########
@@ -295,10 +295,12 @@ public RelNode visit(SortQueryOperation sort) {
List<RexNode> parameters =
convertToRexNodes(calculatedTable.getParameters());
+ // TODO use relBuilder.functionScan() once we remove
TableSqlFunction
return LogicalTableFunctionScan.create(
relBuilder.peek().getCluster(),
Collections.emptyList(),
- relBuilder.call(sqlFunction,
parameters),
+ relBuilder.getRexBuilder()
+
.makeCall(function.getRowType(typeFactory, null, null), sqlFunction,
parameters),
Review comment:
Can you modify the `FlinkTableFunction`, just remove `arguments:
Array[AnyRef]` and `argTypes: Array[Class[_]`, them are useless. The follow-up
plan doesn't depend on them either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
