JingsongLi commented on a change in pull request #11034: [FLINK-15802][table]
Support new type inference for table functions
URL: https://github.com/apache/flink/pull/11034#discussion_r376220459
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/TableFunctionCallGen.scala
##########
@@ -18,29 +18,51 @@
package org.apache.flink.table.planner.codegen.calls
+import org.apache.calcite.rex.RexCall
+import org.apache.flink.table.dataformat.GenericRow
import org.apache.flink.table.functions.TableFunction
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory
+import org.apache.flink.table.planner.codegen.CodeGenUtils.newName
import org.apache.flink.table.planner.codegen.GeneratedExpression.NEVER_NULL
import
org.apache.flink.table.planner.codegen.calls.ScalarFunctionCallGen.prepareFunctionArgs
-import org.apache.flink.table.planner.codegen.{CodeGeneratorContext,
GeneratedExpression}
+import org.apache.flink.table.planner.codegen._
import
org.apache.flink.table.planner.functions.utils.UserDefinedFunctionUtils.getEvalMethodSignature
+import org.apache.flink.table.planner.functions.utils.{TableSqlFunction,
UserDefinedFunctionUtils}
+import org.apache.flink.table.planner.plan.schema.FlinkTableFunction
+import
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
+import org.apache.flink.table.runtime.types.PlannerTypeUtils
+import org.apache.flink.table.types.DataType
import org.apache.flink.table.types.logical.LogicalType
+import scala.collection.JavaConversions._
+
/**
* Generates a call to user-defined [[TableFunction]].
*
* @param tableFunction user-defined [[TableFunction]] that might be
overloaded
*/
-class TableFunctionCallGen(tableFunction: TableFunction[_]) extends
CallGenerator {
+class TableFunctionCallGen(
+ rexCall: RexCall,
+ tableFunction: TableFunction[_])
+ extends CallGenerator {
override def generate(
ctx: CodeGeneratorContext,
operands: Seq[GeneratedExpression],
returnType: LogicalType): GeneratedExpression = {
- // convert parameters for function (output boxing)
- val parameters = prepareUDFArgs(ctx, operands, tableFunction)
- // generate function call
val functionReference = ctx.addReusableFunction(tableFunction)
+
+ val resultCollectorTerm = generateResultCollector(ctx)
+
+ val setCollectorCode = s"""
Review comment:
Minor: just `s"$functionReference.setCollector($resultCollectorTerm);"`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
