[
https://issues.apache.org/jira/browse/FLINK-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032314#comment-17032314
]
Till Rohrmann commented on FLINK-15942:
---------------------------------------
Thanks for creating this issue [~azagrebin]. I think we should fix the logging
because it cluttering the logs and could be confusing.
As a quick fix I like Xintong's idea to say everything above a certain
threshold is interpreted as "infinite"/"undefined"/"whatever". The question is
whether to place this into the {{MemorySize}} and {{CpuResource}} classes or to
keep it rather in the {{ResourceProfile}}? I think it belongs a bit more into
the {{ResourceProfile}} because we express that there is a {{TaskManager}} with
a {{ResourceProfile}} where the number of cpus is infinite/undefined. We could
even think about not adding {{cpuCores}}, {{taskHeapMemory}} and
{{taskOffHeapMemory}} to the result string if they exceed a threshold.
Concerning the threshold, I believe that 1 PB for the memory and 16384 cores
for the CPU cores should be safe enough.
I agree that before introducing an {{INFINITE}} class, we should think about
how it works together. From a mathematical standpoint {{INF + INF = INF}},
{{INF - x = INF}}, {{INF - INF = undefined}}.
> Improve logging of infinite resource profile
> --------------------------------------------
>
> Key: FLINK-15942
> URL: https://issues.apache.org/jira/browse/FLINK-15942
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Configuration, Runtime / Task
> Affects Versions: 1.10.0
> Reporter: Andrey Zagrebin
> Priority: Major
> Fix For: 1.10.1, 1.11.0
>
>
> After we set task memory and CPU to infinity in FLINK-15763, it spoiled the
> logs:
> {code:java}
> 00:23:49,442 INFO
> org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImpl - Free slot
> TaskSlot(index:0, state:ACTIVE, resource profile:
> ResourceProfile{cpuCores=44942328371557892500000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.0000000000000000,
> taskHeapMemory=2097152.000tb (2305843009213693951 bytes),
> taskOffHeapMemory=2097152.000tb (2305843009213693951 bytes),
> managedMemory=20.000mb (20971520 bytes), networkMemory=16.000mb (16777216
> bytes)}, allocationId: 349dacfbf1ac4d0b44a2d11e1976d264, jobId:
> 689a0cf24b40f16b6f45157f78754c46).
> {code}
> We should treat the infinity as a special case and print it accordingly
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
