[ 
https://issues.apache.org/jira/browse/FLINK-15942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032333#comment-17032333
 ] 

Andrey Zagrebin commented on FLINK-15942:
-----------------------------------------

I agree with the quick fix, putting it into ResourceProfile#toString and not 
outputting those huge values at all. At most we risk to not log it in some rare 
cases.

The infinity class would need more thinking but we can design it as a next 
step. I will open a PR for the quick fix soon.

> Improve logging of infinite resource profile
> --------------------------------------------
>
>                 Key: FLINK-15942
>                 URL: https://issues.apache.org/jira/browse/FLINK-15942
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Configuration, Runtime / Task
>    Affects Versions: 1.10.0
>            Reporter: Andrey Zagrebin
>            Priority: Major
>             Fix For: 1.10.1, 1.11.0
>
>
> After we set task memory and CPU to infinity in FLINK-15763, it spoiled the 
> logs:
> {code:java}
> 00:23:49,442 INFO 
> org.apache.flink.runtime.taskexecutor.slot.TaskSlotTableImpl - Free slot 
> TaskSlot(index:0, state:ACTIVE, resource profile: 
> ResourceProfile{cpuCores=44942328371557892500000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000.0000000000000000,
>  taskHeapMemory=2097152.000tb (2305843009213693951 bytes), 
> taskOffHeapMemory=2097152.000tb (2305843009213693951 bytes), 
> managedMemory=20.000mb (20971520 bytes), networkMemory=16.000mb (16777216 
> bytes)}, allocationId: 349dacfbf1ac4d0b44a2d11e1976d264, jobId: 
> 689a0cf24b40f16b6f45157f78754c46).
> {code}
> We should treat the infinity as a special case and print it accordingly



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to