testfixer opened a new pull request #11052: FLINK-15975 Use LinkedHashMap for deterministic iterations URL: https://github.com/apache/flink/pull/11052 ## What is the purpose of the change The test `testMap` in `HiveGenericUDFTest` invokes two methods `HiveGenericUDFTest.init` and `HiveScalarFunction.eval`. These two methods depend on `getConversion` and `toFlinkObject` in class `HiveInspectors`. When the `inspector` is the instance of `MapObjectInspector`, it can return a `HashMap`. However, `HashMap` does not guarantee any specific order of entries. Thus, the test can fail due to a different iteration order. In this PR, we propose to use a `LinkedHashMap` instead to guarantee the iteration order. ## Brief change log In `flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java`, I use LinkedHashMap instead of HashMap in line 108, line 217, and line 316. ## Verifying this change This change is already covered by existing tests, such as *(please describe tests)*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): ( no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (don't know) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
