twalthr commented on a change in pull request #11034: [FLINK-15802][table]
Support new type inference for table functions
URL: https://github.com/apache/flink/pull/11034#discussion_r378218050
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/TableFunctionCallGen.scala
##########
@@ -49,7 +71,7 @@ class TableFunctionCallGen(tableFunction: TableFunction[_])
extends CallGenerato
// has no result
GeneratedExpression(
- functionReference,
+ resultCollectorTerm,
Review comment:
Yes, the logic was also complicated before. Conceptually, I think returning
a collector as a result is better than the function itself. But I agree, I will
add more documentation to the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
