zentol commented on a change in pull request #11070: [FLINK-16013][core] Write 
and parse list config option correctly
URL: https://github.com/apache/flink/pull/11070#discussion_r379314934
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
 ##########
 @@ -958,6 +958,12 @@ private String convertToString(Object o) {
                } else if (o.getClass() == Duration.class) {
                        Duration duration = (Duration) o;
                        return String.format("%d ns", duration.toNanos());
+               } else if (o instanceof List) {
+                       return String.join(";", ((List<?>) 
o).stream().map(Object::toString).toArray(String[]::new));
 
 Review comment:
   Why isn't this using `Collectors.joining(";")`?
   i.e.,
   ```
   return ((List<?>) 
o).stream().map(this::convertToString).collect(Collectors.joining(";"));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to