wangyang0918 commented on a change in pull request #11070: [FLINK-16013][core]
Make complex type config options could be parsed correctly
URL: https://github.com/apache/flink/pull/11070#discussion_r379433432
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
##########
@@ -958,6 +958,12 @@ private String convertToString(Object o) {
} else if (o.getClass() == Duration.class) {
Duration duration = (Duration) o;
return String.format("%d ns", duration.toNanos());
+ } else if (o instanceof List) {
+ return String.join(";", ((List<?>)
o).stream().map(Object::toString).toArray(String[]::new));
Review comment:
I will escape the value string when converting `List` and `Map` to
structured string. Also `Collectors.joining(";")` will make the codes more
concise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
