hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] 
Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379713304
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
                        
<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
                        <fileMode>0644</fileMode>
                </file>
+
+               <!-- ML (API & LIB)  -->
+               <file>
 
 Review comment:
   Hi @dianfu @zentol Thanks for your advice.
   I would fine with adding an uber module. But I think there are some 
differences between the table module and the ml module. For table module, it 
needs a uber module to packages all table sub-modules plus other modules, e.g., 
cep. While for ml, there are no such requirements. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to