[ 
https://issues.apache.org/jira/browse/FLINK-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024511#comment-15024511
 ] 

ASF GitHub Bot commented on FLINK-2996:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1394#discussion_r45733770
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerRangeTest.java
 ---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.blob;
    +
    +import org.apache.flink.configuration.ConfigConstants;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.util.NetUtils;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.io.IOException;
    +import java.net.ServerSocket;
    +
    +/**
    + * Tests to ensure that the BlobServer properly starts on a specified 
range of available ports.
    + */
    +public class BlobServerRangeTest {
    --- End diff --
    
    Should extend `TestLogger` otherwise you don't see in which test you are.


> Add config entry to define BlobServer port
> ------------------------------------------
>
>                 Key: FLINK-2996
>                 URL: https://issues.apache.org/jira/browse/FLINK-2996
>             Project: Flink
>          Issue Type: New Feature
>          Components: JobManager
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>             Fix For: 1.0.0, 0.10.1
>
>
> The blob server currently allocates a random port. To work better together 
> with firewalled clusters, it must be possible to optionally pre-configure the 
> port to a specific value,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to