twalthr commented on a change in pull request #11081: [FLINK-16033][table-api]
Introduced Java Table API Expression DSL
URL: https://github.com/apache/flink/pull/11081#discussion_r380089754
##########
File path:
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/expressionDsl.scala
##########
@@ -1527,6 +874,20 @@ trait ImplicitExpressionConversions {
* e.g. withoutColumns('b to 'c) or withoutColumns('c)
*/
def withoutColumns(head: Expression, tail: Expression*): Expression = {
- unresolvedCall(WITHOUT_COLUMNS, head +: tail: _*)
+ Expressions.withoutColumns(head, tail: _*)
+ }
+
+ /**
+ * Boolean AND in three-valued logic.
+ */
+ def and(predicate0: Expression, predicate1: Expression, predicates:
Expression*): Expression = {
Review comment:
How about other infix notation expressions for the Scala API? `lit()`,
`call()` should also be present here. We should synchronize with `Expressions`?
And add a comment that contributors should synchronize in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
