twalthr commented on a change in pull request #11081: [FLINK-16033][table-api]
Introduced Java Table API Expression DSL
URL: https://github.com/apache/flink/pull/11081#discussion_r380082553
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/rules/ExpandColumnFunctionsRule.java
##########
@@ -140,7 +140,7 @@ public
ColumnFunctionsExpander(List<UnresolvedReferenceExpression> inputFieldRef
/**
* Expands a single column expression to it's real parent's input
references.
*/
- class ColumnsExpressionExpander extends
ApiExpressionDefaultVisitor<List<UnresolvedReferenceExpression>> {
+ static class ColumnsExpressionExpander extends
ApiExpressionDefaultVisitor<List<UnresolvedReferenceExpression>> {
Review comment:
nit: make it private as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
