lirui-apache commented on issue #11093: [FLINK-16055][hive] Avoid catalog functions when listing Hive built-i… URL: https://github.com/apache/flink/pull/11093#issuecomment-587228616 > Hi @lirui-apache thanks for the PR, but I'm not sure about it. If concerned about argument of the public api, shall we just check it and throw exception if the name contains "." in Flink as the input is not a conforming name? @bowenli86 I think the API contract (w/o this PR) is to get the `FunctionInfo` for a given name if it's a built-in function, and `Optional.empty` otherwise. This PR just returns `Optional.empty` for names containing "." because they cannot be built-in functions, which is in line with the contract. The reason to add this short circuit check is to avoid calling `FunctionRegistry.getFunctionInfo` for catalog function names, which can cause problem for tests. More details in the JIRA: https://issues.apache.org/jira/browse/FLINK-16055
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
