JingsongLi commented on a change in pull request #11093: [FLINK-16055][hive] 
Avoid catalog functions when listing Hive built-i…
URL: https://github.com/apache/flink/pull/11093#discussion_r380425268
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
 ##########
 @@ -148,6 +151,9 @@ public CatalogColumnStatisticsDataDate 
toFlinkDateColStats(ColumnStatisticsData
 
        @Override
        public Optional<FunctionInfo> getBuiltInFunctionInfo(String name) {
+               if (isCatalogFunctionName(name)) {
+                       return Optional.empty();
+               }
                Optional<FunctionInfo> functionInfo = getFunctionInfo(name);
 
                if (functionInfo.isPresent() && 
isBuiltInFunctionInfo(functionInfo.get())) {
 
 Review comment:
   I have same question, why not filter by `isBuiltInFunctionInfo`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to