Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45744427
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void testCreateTopologyContext() {
builder.setBolt("bolt2", (IRichBolt) operators.get("bolt2"),
dops.get("bolt2")).allGrouping("spout2");
builder.setBolt("sink", (IRichBolt) operators.get("sink"),
dops.get("sink"))
.shuffleGrouping("bolt1",
TestDummyBolt.groupingStreamId)
- .shuffleGrouping("bolt1",
TestDummyBolt.shuffleStreamId)
- .shuffleGrouping("bolt2",
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2",
TestDummyBolt.shuffleStreamId);
--- End diff --
I see you point. But this PR might be too big anyway. You try to do 3 thing
at the same time (two are backed up by a JIRA). How hard would it be to split
this PR? Last but not least, the multi-input-stream JIRA is not resolved by
this. [And the second JIRA you try to resolve is assigned to me, and I have
already worked on it -- I actually would like to finish my work on it]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
