Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45747566
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void testCreateTopologyContext() {
builder.setBolt("bolt2", (IRichBolt) operators.get("bolt2"),
dops.get("bolt2")).allGrouping("spout2");
builder.setBolt("sink", (IRichBolt) operators.get("sink"),
dops.get("sink"))
.shuffleGrouping("bolt1",
TestDummyBolt.groupingStreamId)
- .shuffleGrouping("bolt1",
TestDummyBolt.shuffleStreamId)
- .shuffleGrouping("bolt2",
TestDummyBolt.groupingStreamId)
.shuffleGrouping("bolt2",
TestDummyBolt.shuffleStreamId);
--- End diff --
I was actually not specifically trying to address JIRA issues but just
fixed everything I discovered on the way while trying out the compatibility
layer. Only after fixing I realized there are open JIRA issues. One is assigned
to me (FLINK-2837] and the other one (FLINK-2721) is open since two months. I
think it would be a shame not to merge this pull request soon. It provides a
good foundation to address any further issues. Splitting this PR should not be
trivial with all the changes.
I already accommodated you with the API changes. Also, I would like to
address most of your comments but I'm not too inclined to split up this PR (if
it is even possible). Could you base your work on this pull request and do a
follow-up?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
