walterddr commented on a change in pull request #10836: [FLINK-11589][Security] 
Support security module and context discovery via ServiceLoader
URL: https://github.com/apache/flink/pull/10836#discussion_r381363305
 
 

 ##########
 File path: docs/_includes/generated/security_configuration.html
 ##########
 @@ -32,6 +38,12 @@
             <td>Boolean</td>
             <td>Indicates whether to read from your Kerberos ticket cache.</td>
         </tr>
+        <tr>
+            <td><h5>security.module.factory.classes</h5></td>
+            <td style="word-wrap: 
break-word;">"org.apache.flink.runtime.security.modules.HadoopModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.JaasModuleFactory";<wbr>"org.apache.flink.runtime.security.modules.ZookeeperModuleFactory"</td>
+            <td>List&lt;String&gt;</td>
+            <td>List of factories that should be used to instantiate security 
modules. All listed modules will be installed. Keep in mind that the configured 
security context might rely on some modules being present.</td>
 
 Review comment:
   `configured security context might rely on some modules being present.` 
   does this means we should throw an exception when installing module? or 
should we return false when `isCompatibleWith` is called? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to