TisonKun commented on issue #10980: [FLINK-12343][flink-yarn] add yarn file 
replication configuration
URL: https://github.com/apache/flink/pull/10980#issuecomment-588822780
 
 
   > > > Do you have a test to update the DFS_REPLICATION_KEY in hdfs-site.xml? 
And then the replication here should be same. I am not sure we could get a 
updated value from yarnConfiguration. Since YarnConfiguration do not add the 
hdfs-site.xml as resource by default.
   > > > > Thanks for giving feedback. Resolved most of them. For the 
YarnConfiguration, yes you are right. By default, the hdfs-site.xml is not 
loaded. Thus, Currently Flink always uses default value. To honor the value 
frrom hdfs-site.xml, I think we need a sperate PR.
   > 
   > I have verified that it could work. Because when we call 
`FileSystem.get(yarnConfiguration)`, the `core-site.xml` and `hdfs-site.xml` 
will be added to resource automatically.
   
   Thanks for your testing!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to