dawidwys commented on a change in pull request #11153: [FLINK-15958][table-common] Introduce unresolved data types in API URL: https://github.com/apache/flink/pull/11153#discussion_r382170607
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/UnresolvedDataType.java ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.table.catalog.DataTypeFactory; +import org.apache.flink.table.types.logical.LogicalType; + +import javax.annotation.Nullable; + +import java.util.function.Function; +import java.util.function.Supplier; + +/** + * Partially resolved data type that requires a lookup in a catalog or configuration before creating + * the corresponding {@link LogicalType}. + * + * <p>Users are able to influence the nullability and conversion class even if the actual {@link LogicalType} + * is not fully known yet. The information is stored and verified when resolving to {@link DataType} + * lazily. + */ +@PublicEvolving +public final class UnresolvedDataType implements AbstractDataType<UnresolvedDataType> { + + private static final String FORMAT = "[%s]"; // indicates that this is an unresolved type + + private final @Nullable Boolean isNullable; + + private final @Nullable Class<?> conversionClass; + + private final Supplier<String> description; + + private final Function<DataTypeFactory, DataType> resolutionFactory; + + private UnresolvedDataType( + @Nullable Boolean isNullable, + @Nullable Class<?> conversionClass, + Supplier<String> description, Review comment: Why do we need a supplier here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
