dawidwys commented on a change in pull request #11153:
[FLINK-15958][table-common] Introduce unresolved data types in API
URL: https://github.com/apache/flink/pull/11153#discussion_r382165231
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DataTypeFactoryImpl.java
##########
@@ -61,19 +63,29 @@
}
@Override
- public Optional<DataType> createDataType(String name) {
+ public <T extends AbstractDataType<T>> DataType
createDataType(AbstractDataType<T> abstractDataType) {
Review comment:
How about we use a wildcard here? We don't care about the type here.
```
DataType createDataType(AbstractDataType<?> abstractDataType)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
