buptljy commented on a change in pull request #11179: 
[FLINK-16178][FLINK-16192][checkpointing] Clean up checkpoint metadata code and 
remove remaining bits of "legacy state"
URL: https://github.com/apache/flink/pull/11179#discussion_r382885940
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointSerializer.java
 ##########
 @@ -52,6 +37,5 @@
         * @return The deserialized savepoint
         * @throws IOException Serialization failures are forwarded
         */
-       T deserialize(DataInputStream dis, ClassLoader userCodeClassLoader) 
throws IOException;
-
+       SavepointV2 deserialize(DataInputStream dis, ClassLoader 
userCodeClassLoader) throws IOException;
 
 Review comment:
   Should we bind #SavepointSerializer to #SavepointV2 ? 
   In this way, we have to create a new interface if we want to add 
#SavepointV3 in the future. Is this expected?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to