klion26 commented on a change in pull request #11179:
[FLINK-16178][FLINK-16192][checkpointing] Clean up checkpoint metadata code and
remove remaining bits of "legacy state"
URL: https://github.com/apache/flink/pull/11179#discussion_r383730724
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointSerializers.java
##########
@@ -35,7 +35,7 @@
private static final Map<Integer, SavepointSerializer<?>> SERIALIZERS =
new HashMap<>(2);
static {
- SERIALIZERS.put(SavepointV1.VERSION,
SavepointV1Serializer.INSTANCE);
+ SERIALIZERS.put(SavepointV1Serializer.VERSION,
SavepointV1Serializer.INSTANCE);
SERIALIZERS.put(SavepointV2.VERSION,
SavepointV2Serializer.INSTANCE);
Review comment:
Seems we just keep the recent savepoint, I'm thinking can we replacing all
`SavepointV2` with `Savepoint` directly, after the replacement, we just have
one `Savepoint` class, no `SavepointVX` class, and update the `VERSION`
property in `Savepoint` when upgrading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
