Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45890269
  
    --- Diff: 
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
 ---
    @@ -89,17 +94,16 @@ public BoltWrapper(final IRichBolt bolt) throws 
IllegalArgumentException {
         * used within a Flink streaming program. The given input schema enable 
attribute-by-name access for input types
         * {@link Tuple0} to {@link Tuple25}. The output type will be one of 
{@link Tuple0} to {@link Tuple25} depending on
         * the bolt's declared number of attributes.
    -    * 
    -    * @param bolt
    +    *  @param bolt
         *            The Storm {@link IRichBolt bolt} to be used.
    +    * @param inputStreamId
    +    * @param inputComponentId
         * @param inputSchema
    -    *            The schema (ie, ordered field names) of the input stream.
    -    * @throws IllegalArgumentException
    -    *             If the number of declared output attributes is not with 
range [0;25].
    --- End diff --
    
    Why do you delete `@throws` ? More documentation is always better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to