Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45890812
  
    --- Diff: 
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapperTwoInput.java
 ---
    @@ -0,0 +1,130 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.storm.wrappers;
    +
    +import backtype.storm.generated.StormTopology;
    +import backtype.storm.topology.IRichBolt;
    +import backtype.storm.tuple.Fields;
    +import org.apache.flink.api.java.tuple.Tuple0;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple25;
    +import org.apache.flink.streaming.api.operators.TwoInputStreamOperator;
    +import org.apache.flink.streaming.api.watermark.Watermark;
    +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
    +
    +import java.util.Collection;
    +
    +/**
    + * A {@link BoltWrapperTwoInput} wraps an {@link IRichBolt} in order to 
execute the Storm bolt within a Flink Streaming
    + * program. In contrast to {@link BoltWrapper}, this wrapper takes two 
input stream as input.
    + */
    +public class BoltWrapperTwoInput<IN1, IN2, OUT> extends BoltWrapper<IN1, 
OUT> implements TwoInputStreamOperator<IN1, IN2, OUT> {
    +
    +   /** The schema (ie, ordered field names) of the second input stream. */
    +   private final Fields inputSchema2;
    +
    +   private final String componentId2;
    +   private final String streamId2;
    +
    --- End diff --
    
    missing JavaDoc for both members


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to