StephanEwen opened a new pull request #11196: [FLINK-16246][connector kinesis] Exclude AWS SDK MBean registry from Kinesis build URL: https://github.com/apache/flink/pull/11196 ## What is the purpose of the change The AWS SDK always registers a MetricAdminMBean at the JMX MBean Server. This allows users to turn on / off more detailed metrics via the JMX admin interface. However, this registered bean keeps the user code classloader alive and thus causes a class leak. Excluding the `com.amazonaws.jmx.SdkMBeanRegistrySupport` class from the connectors disables the default registration thus preventing the class leak. It should only disable that JMX metric admin interface and still allow users to manually configure/activate metrics for the AWS SDK. ## Brief change log - Exclude `com.amazonaws.jmx.SdkMBeanRegistrySupport` from Kinesis fat jar - Add a "shading check" in the build scripts to check whether the class is present in the shaded jar. ## Verifying this change This change has self-contained tests. To test the effectiveness of this, users would need to run a Flink session cluster on AWS and repeatedly submit/cancel a job that uses the Kinesis connector. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no** - The serializers: **no** - The runtime per-record code paths (performance sensitive): **no** - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** - If yes, how is the feature documented? **not applicable**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
