pnowojski commented on a change in pull request #11098: [FLINK-16060][task] 
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r383415907
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamConfigChainer.java
 ##########
 @@ -42,15 +42,17 @@
 /**
  * Helper class to build StreamConfig for chain of operators.
  */
-public class StreamConfigChainer {
+public class StreamConfigChainer<OWNER> {
+       private final OWNER owner;
 
 Review comment:
   It's in order to provide a nice builder like API, for nested builder. That 
after `finish()` call on setting up the chaining, we  can continue configuring 
or build the test harness:
   ```
                        new 
MultipleInputStreamTaskTestHarnessBuilder<>(MultipleInputStreamTask::new, 
BasicTypeInfo.STRING_TYPE_INFO)
                                .addInput(BasicTypeInfo.STRING_TYPE_INFO)
                                .addInput(BasicTypeInfo.STRING_TYPE_INFO)
                                .addInput(BasicTypeInfo.STRING_TYPE_INFO)
                                .setupOperatorChain(new DuplicatingOperator())
                                .chain(new 
OneInputStreamTaskTest.DuplicatingOperator(), 
BasicTypeInfo.STRING_TYPE_INFO.createSerializer(new ExecutionConfig()))
                                .chain(new 
OneInputStreamTaskTest.DuplicatingOperator(), 
BasicTypeInfo.STRING_TYPE_INFO.createSerializer(new ExecutionConfig()))
                                .finish()
                                .setTaskMetricGroup(taskMetricGroup)
                                .build()
   ```
   And `OWNER` is template, so that `finish()` and hence `build()` would return 
correct specific type of the test harness (`MultipleInput`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to