pnowojski commented on a change in pull request #11098: [FLINK-16060][task]
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r383417322
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricNames.java
##########
@@ -42,8 +42,11 @@ private MetricNames() {
public static final String IO_NUM_BUFFERS_OUT_RATE = IO_NUM_BUFFERS_OUT
+ SUFFIX_RATE;
public static final String IO_CURRENT_INPUT_WATERMARK =
"currentInputWatermark";
+ @Deprecated
public static final String IO_CURRENT_INPUT_1_WATERMARK =
"currentInput1Watermark";
+ @Deprecated
public static final String IO_CURRENT_INPUT_2_WATERMARK =
"currentInput2Watermark";
+ public static final String IO_CURRENT_INPUT_WATERMARK_PATERN =
"currentInput%dWatermark";
Review comment:
As previously, even if we re ordered it as prefix, patterns carry more
information and are more concrete/well defined. For example, if you have
prefix, does it mean that there is no suffix or other infix? Pattern mitigates
this ambiguity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
