JingsongLi commented on issue #11205: [FLINK-16265][table] Use LogicalType to 
equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590694517
 
 
   > I'm still not sure about this approach. Because the DataType stored in the 
TableSchema may still hold the different conversion classes.
   > 
   > Btw, if we want to go with this approach, we should create another JIRA 
issue to have an explicit title and a `Table SQL/API` module. Otherwise, the 
API change is too silent.
   
   Created https://issues.apache.org/jira/browse/FLINK-16270 .
   
   This is a pit, if not repaired, I think it will lead to more problems.
   
   Conversion classes should not exist in `TableSchema`, but for legacy 
planner, it is hard to remove this.
   
   The origin of this problem is in `DescriptorProperties`, it not serialize 
conversion classes in `TableSchema`. After `putTableSchema` and 
`getTableSchema`, conversion classes changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to