JingsongLi commented on issue #11205: [FLINK-16265][table] Use LogicalType to 
equals in TableSchema
URL: https://github.com/apache/flink/pull/11205#issuecomment-590698568
 
 
   > If the `TableSchema` only accept/store new types, I think it's fine to 
refactor the equals. However, as you said, legacy planner is still using the 
old types in TableSchema. That's why I'm not sure whether there is problem to 
refactor equals.
   
   Whether it's legacy or blink, conversion classes in `TableSchema` have no 
actual meaning.
   The role of conversion classes in legacy planner is to get the old 
`SqlTimestampTypeInfo`. Not mean it treats different conversion classes 
differently.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to