wuchong commented on a change in pull request #11061: [FLINK-15782]
[connectors/jdbc] JDBC sink DataStream API
URL: https://github.com/apache/flink/pull/11061#discussion_r383726014
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
##########
@@ -187,25 +199,20 @@ public JDBCOutputFormatBuilder setSqlTypes(int[]
typesArray) {
* @return Configured JDBCOutputFormat
*/
public JDBCOutputFormat finish() {
+ return new JDBCOutputFormat(new
SimpleJdbcConnectionProvider(buildConnectionOptions()),
Review comment:
Please break each argument into a separate line, including the first one.
This is also mentioned in the Flink Code Style:
https://flink.apache.org/contributing/code-style-and-quality-formatting.html#breaking-the-lines-of-too-long-statements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
