wuchong commented on a change in pull request #11061: [FLINK-15782]
[connectors/jdbc] JDBC sink DataStream API
URL: https://github.com/apache/flink/pull/11061#discussion_r383692265
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
##########
@@ -37,25 +36,36 @@
* @see Row
* @see DriverManager
*/
-public class JDBCOutputFormat extends AbstractJDBCOutputFormat<Row> {
+/**
+ * @deprecated use {@link JdbcBatchingOutputFormat}
+ */
+@Deprecated
+public class JDBCOutputFormat extends AbstractJdbcOutputFormat<Row> {
private static final long serialVersionUID = 1L;
private static final Logger LOG =
LoggerFactory.getLogger(JDBCOutputFormat.class);
- private final String query;
- private final int batchInterval;
- private final int[] typesArray;
+ final JdbcInsertOptions insertOptions;
+ private final JdbcExecutionOptions batchOptions;
- private PreparedStatement upload;
- private int batchCount = 0;
+ private transient PreparedStatement upload;
+ private transient int batchCount = 0;
- public JDBCOutputFormat(String username, String password, String
drivername,
- String dbURL, String query, int batchInterval, int[]
typesArray) {
- super(username, password, drivername, dbURL);
- this.query = query;
- this.batchInterval = batchInterval;
- this.typesArray = typesArray;
+ /**
+ * @deprecated use {@link #JDBCOutputFormat(JdbcConnectionProvider,
JdbcInsertOptions, JdbcExecutionOptions)}}.
+ */
+ @Deprecated
+ public JDBCOutputFormat(String username, String password, String
drivername, String dbURL, String query, int batchInterval, int[] typesArray) {
+ this(new SimpleJdbcConnectionProvider(new
JdbcConnectionOptions(dbURL, drivername, username, password)),
+ new JdbcInsertOptions(query, typesArray),
+
JdbcExecutionOptions.builder().withBatchSize(batchInterval).build());
+ }
+
+ public JDBCOutputFormat(JdbcConnectionProvider connectionProvider,
JdbcInsertOptions insertOptions, JdbcExecutionOptions batchOptions) {
Review comment:
We should recommend users to use builders instead of public constructors.
Make it `private`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
