tzulitai opened a new pull request #35: [FLINK-16274] Support inlined 
configuration in StatefulFunctionsAppContainers
URL: https://github.com/apache/flink-statefun/pull/35
 
 
   This PR is based on #34. The first 4 commits are not relevant.
   
   ---
   
   ### Goal
   
   This PR achieves the following things:
   - Change the `StatefulFunctionsAppContainers` to a more "builder-ish" 
approach, which the user provides settings on how the containers are built, and 
only on `before()` the test we build the containers and application images. 
This would allow a more fluent API to inline configuration settings.
   - Add inline configuration setting methods, like so:
   ```
   @Rule
   public StatefulFunctionsAppContainers verificationApp =
       new StatefulFunctionsAppContainers("app-name", numWorkers)
           .withModuleGlobalConfiguration("key", "value");
           .withConfiguration(ConfigOption<T> option, T value);
   ```
   This also eliminates the need for users of `StatefulFunctionsAppContainers` 
to maintain a `flink-conf.yaml` in their classpath, as they can now build the 
configuration fully programmatically with the new inline configuration methods.
   
   ---
   
   ### Verifying
   
   This is only changes in tests.
   Run `mvn clean verify -Prun-e2e-tests` to verify changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to