Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1409#discussion_r45973129
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
    @@ -243,6 +243,20 @@
         */
        public static final String YARN_PROPERTIES_FILE_LOCATION = 
"yarn.properties-file.location";
     
    +   /**
    +    * Prefix for passing custom environment variables to Flink's 
ApplicationMaster (JobManager).
    +    * For example for passing LD_LIBRARY_PATH as an env variable to the 
AppMaster, set:
    +    *      yarn.application-master.env.LD_LIBRARY_PATH: "/usr/lib/native"
    +    * in the flink-conf.yaml.
    +    */
    +   public static final String YARN_APPLICATION_MASTER_ENV_PREFIX = 
"yarn.application-master.env.";
    +
    +   /**
    +    * Similar to the {@see YARN_APPLICATION_MASTER_ENV_PREFIX}, this 
configuration prefix allows
    +    * setting custom environment variables.
    +    */
    +   public static final String YARN_TASK_MANAGER_ENV_PREFIX = 
"yarn.taskmanager.env.";
    --- End diff --
    
    I think `YARN_RESOURCE_MANAGER_ENV_PREFIX` is just wrong bc its a service 
of YARN, not of Flink 
(http://hortonworks.com/blog/apache-hadoop-yarn-resourcemanager/).
    
    Whether to use AM or JM is a good question. In the YARN context, AM and JM 
are basically the same. I think AM is a bit more consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to