zhuzhurk commented on a change in pull request #11213: [FLINK-16276][tests] 
Introduce a builder and factory methods to create DefaultScheduler for testing
URL: https://github.com/apache/flink/pull/11213#discussion_r384459803
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SchedulerTestingUtils.java
 ##########
 @@ -77,6 +94,47 @@
 
        private static final long DEFAULT_CHECKPOINT_TIMEOUT_MS = 10 * 60 * 
1000;
 
+       private static final Time DEFAULT_TIMEOUT = Time.seconds(300);
+
+       private SchedulerTestingUtils() {}
+
+       public static DefaultSchedulerBuilder newSchedulerBuilder(final 
JobGraph jobGraph) {
+               return new DefaultSchedulerBuilder(jobGraph);
+       }
+
+       public static DefaultSchedulerBuilder 
newSchedulerBuilderWithDefaultSlotAllocator(
 
 Review comment:
   It will be used when we change some tests to create DefaultScheduler, one 
example can be found in `DefaultSchedulerBatchSchedulingTest#createScheduler()` 
in #10858 .
   Another example is `ExecutionGraphSuspendTest` which currently create 
ExecutionGraph and with a given slotProvider.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to