zhuzhurk commented on a change in pull request #11213: [FLINK-16276][tests]
Introduce a builder and factory methods to create DefaultScheduler for testing
URL: https://github.com/apache/flink/pull/11213#discussion_r384936512
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -123,15 +121,15 @@ public DefaultScheduler(
backPressureStatsTracker,
ioExecutor,
jobMasterConfiguration,
- slotProvider,
+ new ThrowingSlotProvider(), // this is not used any
more in the new scheduler
futureExecutor,
userCodeLoader,
checkpointRecoveryFactory,
rpcTimeout,
new
ThrowingRestartStrategy.ThrowingRestartStrategyFactory(),
blobWriter,
jobManagerJobMetricGroup,
- slotRequestTimeout,
+ Time.seconds(0), // this is not used any more in the
new scheduler
Review comment:
We can also remove these 2 params from the constructor of SchedulerBase once
we have removed the legacy scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
