zhuzhurk opened a new pull request #11230: [FLINK-16300] Rework 
SchedulerTestUtils with testing classes to replace mockito usages
URL: https://github.com/apache/flink/pull/11230
 
 
   ## What is the purpose of the change
   
   Mockito is used in SchedulerTestUtils to mock ExecutionVertex and Execution 
for testing. It fails to mock every getter so that other tests use it may 
encounter NPE issues, e.g. ExecutionVertex#getID().
   Mockito is also discouraged to be used in Flink tests. So I'd propose to 
rework the utils with testing classes.
   
   ## Brief change log
   
   Reworked the SchedulerTestUtils methods with testing classes.
   
   ## Verifying this change
   
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to