dianfu commented on a change in pull request #11220: [FLINK-16249][python][ml]
Add interfaces for Params, ParamInfo and WithParams
URL: https://github.com/apache/flink/pull/11220#discussion_r384958403
##########
File path: flink-python/setup.py
##########
@@ -224,7 +224,7 @@ def remove_if_exists(file_path):
author_email='[email protected]',
python_requires='>=3.5',
install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0',
'apache-beam==2.19.0',
- 'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1'],
+ 'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1',
'jsonpickle==1.2'],
Review comment:
From user's perspective, not every PyFlink user is a ML user and so it
doesn't make sense to force a non-ML user to install a dependency which is only
used in ML.
Maybe we should define a clear stragey for such dependencies. Handling it
from the perspective of package size is one option, but I'm not sure if it's
the best. For example, what to do with the other dependencies which may be
introduced in the future, e.g. pandas for vectorized Python UDF support, numpy
for ML support, etc? These dependencies maybe not small. Should we make them as
optional or required dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
